Re: [PATCH] arm/rpc: avoid static keyword removal via define

[Russell King - ARM Linux]

On Wed, Dec 17, 2014 at 04:29:46PM +0100, Christian Borntraeger wrote:
> Am 16.12.2014 um 12:40 schrieb Russell King - ARM Linux:
> > On Tue, Dec 16, 2014 at 12:15:54PM +0100, Christian Borntraeger wrote:
> >> Am 15.12.2014 um 09:48 schrieb Christian Borntraeger:
> >>> commit 4486b86368d7 ("[ARM] riscpc: fix decompressor font file handling")
> >>> introduced Makefile magic to avoid building a file two times. Using
> >>> -Dstatic= does break some assumptions on compiler.h that were introduced
> >>> for READ_ONCE.
> >>>
> >>> Lets just use sed on the copy instead of using a define.
> >>>
> >>> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> >>> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> >>
> >> This fixed the linux-next build http://kisskb.ellerman.id.au/kisskb/target/1508/
> >> Unless anybody complains, I will send the pull request for the access_once tree tomorrow and I have this patch applied on top.
> > 
> > Please give me some time to look at this.
> 
> >From all builds, the only problematic case was the rpc_defconfig.
> So only CONFIG_ARCH_ACORN is affected.
> 
> As I said, I want to send this series this merge window, so if you
> do not find the time to look into this before rc1, what about removing
> this patch from my queue and we solve this later? 
> Acorn Risc CPU is probably not the hottest platform right now, so if we 
> fix this in rc2 or rc3 this might be ok - I guess.

How does compiler.h get included when building font.o?

Since I haven't seen your patch series, I guess it gets included somehow
via linux/types.h ?

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/