Re: [PATCH] tools lib traceevent: Add support for IP address formats

[David Ahern]

On 12/17/14 9:26 PM, Namhyung Kim wrote:
> It'd be better if we do it like below..
>
> 	char i = *ptr++;
>
> Why not passing ptr + 1 to print_ip_arg()?

That parsing loop is a bit weird - and deep. And I only wanted to 
consume 'pi' and 'pI' with parse_ip_arg if and only if the next letters 
are '4', '6' and 'S'.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/