Re: [PATCH] tools lib traceevent: Add support for IP address formats

[David Ahern]

On 12/18/14 8:52 AM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Dec 18, 2014 at 08:10:43AM -0700, David Ahern escreveu:
> > Adds helper for following kernel formats:
> >    %pi4 print an IPv4 address with leading zeros
> >    %pI4 print an IPv4 address without leading zeros
> >    %pi6 print an IPv6 address without colons
> >    %pI6 print an IPv6 address with colons
> >    %pI6c print an IPv6 address with colons
> >    %pISpc print an IP address from a sockaddr
> >
> > Allows these formats to be used in tracepoints.
> >
> > Quite a bit of this is adapted from code in lib/vsprintf.c.
>
> Can't we try as much as possible use that code directly? Something like

By my reading of that file I don't see how it can be reused directly.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/