Re: [PATCH v5 4/6] staging: fpga manager: add driver for socfpga fpga manager

[atull]

On Thu, 18 Dec 2014, Michal Simek wrote:

Hi Michal,

> > +
> > +	/* Write out remaining non 32-bit chunks. */
> > +	switch (count) {
> > +	case 3:
> > +		socfpga_fpga_data_writel(priv, buffer_32[i++] & 0x00ffffff);
> > +		break;
> > +	case 2:
> > +		socfpga_fpga_data_writel(priv, buffer_32[i++] & 0x0000ffff);
> > +		break;
> > +	case 1:
> > +		socfpga_fpga_data_writel(priv, buffer_32[i++] & 0x000000ff);
> > +		break;
> > +	default:
> > +		/* This will never happen. */
> 
> why not just return any error code here even if this can't happen.
> 

OK. Will be in v6.

> 
> add it to one line.
> 
> The rest is looks good to me. I think this is good to go in.
> 
> Acked-by: Michal Simek <michal.simek@xxxxxxxxxx>
> 
> Thanks,
> Michal
> 

Thanks for the feedback.  So patches 1-4 look good now?

For v6 I will leave out patches 5/6 and 6/6.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/