Re: [PATCH] genirq: fix symbol export for __irq_set_affinity

From: Jesse Brandeburg
Date: Thu Dec 18 2014 - 17:48:48 EST


On Thu, 18 Dec 2014 23:42:03 +0100
Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> On Thu, 18 Dec 2014, Jesse Brandeburg wrote:
> > Enabling this function means that kernel drivers can include
> > an initial affinity setting for the interrupt, instead of all
> > interrupts starting out life on CPU0. It seems to have just
> > been an oversight that it was not included.

> And why needs this to be called from modules? Just because or is there
> a legitimate reason? IOW, you forgot to describe the actual usecase.

As stated above, the use case for my interest is making a network
driver's many interrupt vectors not all show up on CPU0. Of course a
user can work around this by manually tuning smp_affinity, but I have
seen many reports from users and testers where the performance of the
network was really bad due to all network interrupts on CPU0.

This allows the driver to set a sane default smp_affinity value at
driver load.

Would you instead consider a patch where if a user calls the
set_irq_affinity_hint that the initial affinity is set to the hinted
value?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/