Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness

From: Nicholas A. Bellinger
Date: Thu Dec 18 2014 - 20:20:08 EST


Hi Kyle,

On Thu, 2014-12-18 at 12:57 -0500, Kyle McMartin wrote:
> scripts/headers_install.sh will transform __packed to
> __attribute__((packed)), so the #ifndef is not necessary.
> (and, in fact, it's problematic, because we'll end up with the header
> containing:
> #ifndef __attribute__((packed))
> #define __attribu...
> and so forth.)
>
> Cc: stable@xxxxxxxxxxxxxxx # 3.18
> Signed-off-by: Kyle McMartin <kyle@xxxxxxxxxx>
>
> ---
> cc-ing stable@ so this headers fix gets picked up by distros.
>
> --- a/include/uapi/linux/target_core_user.h
> +++ b/include/uapi/linux/target_core_user.h
> @@ -6,10 +6,6 @@
> #include <linux/types.h>
> #include <linux/uio.h>
>
> -#ifndef __packed
> -#define __packed __attribute__((packed))
> -#endif
> -
> #define TCMU_VERSION "1.0"
>
> /*

Applied to target-pending/for-next.

Thanks!

--nab


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/