Re: [PATCH 3/3] [SCSI] mpt2sas: Remove unnecessary use of a boolean variable

[Joe Perches]

On Fri, 2014-12-19 at 12:13 +0100, Quentin Lambert wrote:
[]
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
[]
> @@ -1414,12 +1414,8 @@ _base_enable_msix(struct MPT2SAS_ADAPTER *ioc)
>  	struct msix_entry *entries, *a;
>  	int r;
>  	int i;
> -	u8 try_msix = 0;
>  
> -	if (msix_disable == -1 || msix_disable == 0)
> -		try_msix = 1;
> -
> -	if (!try_msix)
> +	if (msix_disable != -1 || msix_disable != 0)
>  		goto try_ioapic;

logic not the same.

Now needs && not ||


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/