[PATCH 2/3] microblaze: intc: Refactor DT sanity check

From: Soren Brinkmann
Date: Fri Dec 19 2014 - 13:21:25 EST


Avoid funky casts and arithmetic.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xxxxxxxxxx>
---
arch/microblaze/kernel/intc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/microblaze/kernel/intc.c b/arch/microblaze/kernel/intc.c
index 01ae73088578..8965fd379570 100644
--- a/arch/microblaze/kernel/intc.c
+++ b/arch/microblaze/kernel/intc.c
@@ -157,7 +157,7 @@ static int __init xilinx_intc_of_init(struct device_node *intc,
return ret;
}

- if (intr_mask > (u32)((1ULL << nr_irq) - 1))
+ if (intr_mask >> nr_irq)
pr_info(" ERROR: Mismatch in kind-of-intr param\n");

pr_info("%s: num_irq=%d, edge=0x%x\n",
--
2.2.0.1.g9ee0458

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/