Re: [PATCH] audit: use supplied gfp_mask from audit_buffer in kauditd_send_multicast_skb

From: Valdis . Kletnieks
Date: Fri Dec 19 2014 - 19:53:25 EST


On Thu, 18 Dec 2014 23:09:27 -0500, Richard Guy Briggs said:
> Eric Paris explains: Since kauditd_send_multicast_skb() gets called in
> audit_log_end(), which can come from any context (aka even a sleeping context)
> GFP_KERNEL can't be used. Since the audit_buffer knows what context it should
> use, pass that down and use that.
>
> See: https://lkml.org/lkml/2014/12/16/542

> Reported-by: Valdis Kletnieks <Valdis.Kletnieks@xxxxxx>
> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
> ---
> kernel/audit.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 7b83c55..ce484fb 100644

I was reliably triggering 3-4 BUGs an hour, and with this patch applied I've
gone 9 hours without seeing one.

So feel free to add a Tested-By: when it goes out.

Attachment: pgpgMo5oQZacb.pgp
Description: PGP signature