Re: [PATCH] scripts: dtc: libfdt: fdt_rw.c: Remove some unused functions

From: Rob Herring
Date: Sun Dec 21 2014 - 18:22:39 EST


On Sun, Dec 21, 2014 at 11:40 AM, Rickard Strandqvist
<rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote:
> Removes some functions that are not used anywhere:
> fdt_delprop() fdt_add_mem_rsv()
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
> ---
> scripts/dtc/libfdt/fdt_rw.c | 32 -----------------------------
> scripts/dtc/libfdt/libfdt.h | 48 -------------------------------------------
> 2 files changed, 80 deletions(-)

These sources are just imported unmodified from libfdt, so we don't
want to be changing them in the kernel. Also, I think these functions
could be needed at some point. Getting -ffunction-sections to work
with the kernel would be the right way to solve this IMHO.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/