Re: [PATCH] tools: perf: util: color.c: Remove some unused functions

[Jiri Olsa]

On Sat, Dec 20, 2014 at 01:51:05PM +0100, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> color_parse_mem() color_parse()
> 
> This was partially found by using a static code analysis program called cppcheck.

and partially removed ;-)

[jolsa@krava perf]$ make
  BUILD:   Doing 'make -j4' parallel build
  CC       util/debug.o
  CC       util/color.o
  CC       util/machine.o
  CC       util/map.o
util/color.c:8:12: error: âparse_colorâ defined but not used [-Werror=unused-function]
 static int parse_color(const char *name, int len)
            ^
util/color.c:28:12: error: âparse_attrâ defined but not used [-Werror=unused-function]
 static int parse_attr(const char *name, int len)
            ^
cc1: all warnings being treated as errors
make[1]: *** [util/color.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2


any clue why this (color name parsing) is in?

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/