[PATCH] [PATCH v2 2/6] dgnc/dgnc_sysfs.c: checkpatch: Use of dev_err ? instead of printk
From: Simone Weiss
Date: Mon Dec 22 2014 - 13:44:08 EST
I originally wanted to replace both of the printk cals in this file with dev_err().
But in the function dgnc_create_driver_sysfiles only the struct pci_driver was given,
sadly I coudn't figure out a way to get a struct device when only a struct pci_driver is given.
Signed-off-by: Simone Weiss <simone.weiss@xxxxxx>
Signed-off-by: Helene Gsaenger <helene.gsaenger@xxxxxxxxxxxxxx>
---
drivers/staging/dgnc/dgnc_sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c
index 2fd34ca..8be3b51 100644
--- a/drivers/staging/dgnc/dgnc_sysfs.c
+++ b/drivers/staging/dgnc/dgnc_sysfs.c
@@ -360,7 +360,8 @@ void dgnc_create_ports_sysfiles(struct dgnc_board *bd)
rc |= device_create_file(&(bd->pdev->dev), &dev_attr_vpd);
rc |= device_create_file(&(bd->pdev->dev), &dev_attr_serial_number);
if (rc)
- printk(KERN_ERR "DGNC: sysfs device_create_file failed!\n");
+ dev_err(&(bd->pdev->dev),
+ "DGNC: sysfs device_create_file failed!\n");
}
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/