Re: [PATCH] lib: proportions.c: Remove some unused functions

[Andrew Morton]

On Sat, 20 Dec 2014 15:51:53 +0100 Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote:

> Removes some functions that are not used anywhere:
> prop_change_shift() prop_descriptor_init() prop_fraction_percpu() prop_fraction_single() __prop_inc_percpu_max() prop_local_destroy_percpu() prop_local_destroy_single() prop_local_init_percpu() prop_local_init_single()
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> ---
>  include/linux/proportions.h |   14 ----
>  lib/proportions.c           |  177 -------------------------------------------
>  2 files changed, 191 deletions(-)

Gee, that's a heck of a lot of dead code.

Peter, what was the thinking here?  Was this code once used, or added
for API completeness or what?

Perhaps we should just ifdef it out, so the code is still sitting there if
someone wishes to resurrect it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/