Re: [PATCH] proc: task_mmu: show page size in /proc/<pid>/numa_maps

From: David Rientjes
Date: Mon Dec 22 2014 - 17:21:43 EST


On Mon, 22 Dec 2014, Dave Hansen wrote:

> > Remaining question here is: should we print out 'pagesize' deliberately
> > or conditionally, only to disambiguate cases where page_size != PAGE_SIZE?
>
> I say print it unconditionally. Not to completely overdesign this, but
> I do think we should try to at least mirror the terminology that smaps uses:
>
> KernelPageSize: 4 kB
> MMUPageSize: 4 kB
>
> So definitely call this kernelpagesize.
>

Feel free to add my acked-by if this patch prints it unconditionally and
renames this to kernelpagesize per Dave. I agree we need to leave "huge"
for existing dependencies even though we have multiple possible hugepage
sizes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/