Re: [RFC PATCH 01/17] block: make generic_make_request handle arbitrarily sized bios

[Dongsu Park]

On 23.12.2014 11:14, Geoff Levand wrote:
> On Mon, 2014-12-22 at 12:48 +0100, Dongsu Park wrote:
> > From: Kent Overstreet <kmo@xxxxxxxxxxxxx>
> 
> > --- a/drivers/block/ps3vram.c
> > +++ b/drivers/block/ps3vram.c
> > @@ -603,6 +603,8 @@ static void ps3vram_make_request(struct request_queue *q, struct bio *bio)
> >  	struct ps3vram_priv *priv = ps3_system_bus_get_drvdata(dev);
> >  	int busy;
> >  
> > +	blk_queue_split(q, &bio, q->bio_split);
> > +
> >  	dev_dbg(&dev->core, "%s\n", __func__);
> >  
> >  	spin_lock_irq(&priv->lock);
> 
> The dev_dbg() here marks the entry to ps3vram_make_request(), so
> we should put the blk_queue_split() call after the dev_dbg() call.

Okay, I'll do it. Thanks for the review.

Dongsu

> -Geoff
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/