Re: [PATCH 05/37] perf tools: Create separate mmap for dummy tracking event

[Namhyung Kim]

On Fri, Dec 26, 2014 at 7:08 AM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> On Wed, Dec 24, 2014 at 04:15:01PM +0900, Namhyung Kim wrote:
>> When multi file support is enabled, a dummy tracking event will be
>> used to track metadata (like task, comm and mmap events) for a session
>> and actual samples will be recorded in separate files.
>>
>> Provide separate mmap to the dummy tracking event.  The size is fixed
>> to 128KiB (+ 1 page) as the event rate will be lower than samples.  I
>> originally wanted to use a single mmap for this but cross-cpu sharing
>> is prohibited so it's per-cpu (or per-task) like normal mmaps.
>
> maybe this needs to be applied after next patch?
>   perf tools: Introduce perf_evlist__mmap_multi

Oops, sorry.  it seems the code was mixed after huge number of
rebase..  The commit order is right but it just has a wrong hunk.


>
> I'm getting compile error:
>
> [jolsa@krava perf]$ make JOBS=1
>   BUILD:   Doing 'make -j1' parallel build
>   CC       util/evlist.o
> util/evlist.c: In function âperf_evlist__mmap_per_evselâ:
> util/evlist.c:937:9: error: âstruct mmap_paramsâ has no member named âtrackâ
>    if (mp->track && perf_evsel__is_dummy_tracking(evsel)) {
>          ^
> util/evlist.c: In function âperf_evlist__mmapâ:
> util/evlist.c:1092:62: error: âuse_track_mmapâ undeclared (first use in this function)
>   if (evlist->mmap == NULL && perf_evlist__alloc_mmap(evlist, use_track_mmap) < 0)
>                                                               ^
> util/evlist.c:1092:62: note: each undeclared identifier is reported only once for each function it appears in
> make[1]: *** [util/evlist.o] Error 1
> make: *** [all] Error 2

Will fix, thanks
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/