Re: [PATCH] x86: Fix multiple coding style issues

From: Alexander Kuleshov
Date: Fri Dec 26 2014 - 12:14:04 EST


> Jeremiah Mahler <jmmahler@xxxxxxxxx>:
If you are looking for things to fix I suggest looking in the
drivers/staging directory. There are lots of things that need to be
fixed in there.

Ah sorry, read it incorrectly.

2014-12-26 23:09 GMT+06:00 Alexander Kuleshov <kuleshovmail@xxxxxxxxx>:
> Hello Jeremiah,
>
> Thank you for feedback. It is my first patches to kernel, so i have a
> some little questions:
>
>> Jeremiah Mahler <jmmahler@xxxxxxxxx>:
>> Alexander,
>>
>> On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:
>>
>> Your description needs to be more specific than just "coding style
>> fixes". What type of problems did you fix? How did you find them?
>>
>
> There are some lines which more than 80 chars, I found it with
> scripts/checkpatch.pl.
> What is the best place to put this description? In commit message
> after first line?
>
>> Jeremiah Mahler <jmmahler@xxxxxxxxx>:
>> If you are looking for things to fix I suggest looking in the
>> drivers/staging directory. There are lots of things that need to be
>> fixed in there.
>
> So i must make this patch for kernel/git/gregkh/staging.git and resend
> it again or just to add to this thread?
> Or i'm wrong?
>
> Thank you.



--
_________________________
0xAX
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/