Re: [PATCH 11/37] perf tools: Introduce thread__comm_time() helpers

From: Namhyung Kim
Date: Sat Dec 27 2014 - 00:37:25 EST


On Sat, Dec 27, 2014 at 2:00 AM, David Ahern <dsahern@xxxxxxxxx> wrote:
> On 12/24/14 12:15 AM, Namhyung Kim wrote:
>>
>> @@ -139,6 +161,16 @@ const char *thread__comm_str(const struct thread
>> *thread)
>> return comm__str(comm);
>> }
>>
>> +const char *thread__comm_time_str(const struct thread *thread, u64
>> timestamp)
>> +{
>> + const struct comm *comm = thread__comm_time(thread, timestamp);
>> +
>> + if (!comm)
>> + return NULL;
>> +
>> + return comm__str(comm);
>> +}
>> +
>
>
> thread__comm_str_time()? time_str suggests a time-based string as opposed to
> a comm_str based on time.

Will change - my naming sense is always awful. I'd be happy to hear
any naming suggestion. ;-)

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/