Re: [PATCH v2] gru: cleanup on stack DECLARE_COMPLETION

[Dimitri Sivanich]

Acked-by: Dimitri Sivanich <sivanich@xxxxxxx>

On Mon, Dec 29, 2014 at 01:31:16PM -0500, Nicholas Mc Guire wrote:
> fix-up for incorrect use of DECLARE_COMPLETION. see also commit
> 6e9a4738 ("completions: lockdep annotate on stack completions")
> 
> V2: split out patch for individual files and (hopefully) proper
>     labeling this time
> 
> patch is against linux-next 3.19.0-rc1 -next-20141226
> 
> patch was compile tested with defconfig_x86_64 + CONFIG_IRQ_REMAP=y
> CONFIG_X86_X2APIC=y, CONFIG_X86_UV=y, CONFIG_SGI_GRU=y
> 
> Signed-off-by: Nicholas Mc Guire <der.herr@xxxxxxx>
> ---
>  drivers/misc/sgi-gru/grukservices.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 913de07..abf2b73 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -1044,7 +1044,7 @@ done:
>  
>  static int quicktest2(unsigned long arg)
>  {
> -	static DECLARE_COMPLETION(cmp);
> +	static DECLARE_COMPLETION_ONSTACK(cmp);
>  	unsigned long han;
>  	int blade_id = 0;
>  	int numcb = 4;
> -- 
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/