Re: esp_scsi: make number of tags configurable

[Christoph Hellwig]

On Wed, Dec 10, 2014 at 11:16:47AM +0100, Geert Uytterhoeven wrote:
> > --- a/drivers/scsi/esp_scsi.c
> > +++ b/drivers/scsi/esp_scsi.c
> > @@ -2317,6 +2317,10 @@ int scsi_esp_register(struct esp *esp, struct device *dev)
> >         static int instance;
> >         int err;
> >
> > +       if (!esp->num_tags)
> > +               esp->num_tags = ESP_DEFAULT_TAGS;
> > +       else if (esp->num_tags >= ESP_MAX_TAG)
> 
> drivers/scsi/esp_scsi.c: In function ???scsi_esp_register???:
> drivers/scsi/esp_scsi.c:2399: warning: comparison is always false due
> to limited range of data type
> 
> ESP_MAX_TAG is 256, num_tags is u8.

Can you send me a patch to just remove that conditional?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/