Re: [PATCH 3/3] ARM: edma: Split up header file to platform_data and API file

[Peter Ujfalusi]

On 12/08/2014 02:49 PM, Vinod Koul wrote:
> On Thu, Nov 27, 2014 at 12:41:31PM +0200, Peter Ujfalusi wrote:
>> include/linux/platform_data/ is not a correct place to keep the API
>> definitions for edma, it is meant to be only for the pdata for the device.
>> Clean up this by moving the API to include/linux/edma.h
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
>> ---
>>  arch/arm/common/edma.c                     |   3 +-
>>  arch/arm/mach-davinci/devices.c            |   1 +
>>  arch/arm/mach-davinci/include/mach/da8xx.h |   1 +
>>  drivers/dma/edma.c                         |   2 +-
>>  include/linux/edma.h                       | 153 +++++++++++++++++++++++++++++
>>  include/linux/platform_data/edma.h         | 148 ++--------------------------
>>  sound/soc/davinci/davinci-pcm.h            |   1 +
>>  7 files changed, 165 insertions(+), 144 deletions(-)
>>  create mode 100644 include/linux/edma.h
> I was hoping that this will have delete for platform_data/edma.h, do we
> still need that and why shouldn't we get rid of this :)

We still need it for the legacy boot of davinci devices. We can boot some
davinci SoC/boards with DT, but not all of them.

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/