Re: [PATCH] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

From: Serguey Parkhomovsky
Date: Tue Dec 30 2014 - 22:04:52 EST


On Tue, Dec 30, 2014 at 02:35:18PM -0800, Jeremiah Mahler wrote:
>
> If you look at the source code just below these functions you will find:
>
> EXPORT_SYMBOL(libcfs_arch_init);
> EXPORT_SYMBOL(libcfs_arch_cleanup);
>
> So making these static is incorrect because they are being used outside
> of this file.
>

Thanks for the review, and sorry about the noise; I'll be more careful next time.

Serguey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/