Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace
From: Joe Perches
Date: Thu Jan 01 2015 - 00:40:34 EST
On Thu, 2015-01-01 at 10:17 +0530, Sudip Mukherjee wrote:
> On Wed, Dec 31, 2014 at 09:33:43PM +0000, Lorenzo Stoakes wrote:
> > This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace
> > in r8192U_dm.c and additionally it removes inconsistent whitespace
> > throughout.
> >
> > Additionally some 0x00... padding has been added for alignment to the
> > edca_setting_* variables.
>
> i may be wrong, but looks like you are doing many different things in the patch, not just whitespace errors.
> marked a few, please see inline -
Don't get carried away with patch type separation
and please remember to trim your replies to just
the areas you comment on.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/