Re: [PATCH] block: fix checking return value of blk_mq_init_queue

[Al Viro]

On Fri, Jan 02, 2015 at 08:53:11AM -0700, Jens Axboe wrote:
> On 01/02/2015 07:25 AM, Ming Lei wrote:
> >Check IS_ERR_OR_NULL(return value) instead of just return value.
> 
> Thanks Ming, applied.

Umm...  Looking at the callers, I'd suggest making it _never_ return NULL -
it's always treates as ERR_PTR(-ENOMEM) anyway.  Then the checks would be
just IS_ERR(...).

IS_ERR_OR_NULL() is very often a sign of lousy calling conventions and
this case is no exception...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/