Re: [PATCH] staging: rtl8192e: Fix duplicated conditional branch

From: Joe Perches
Date: Sun Jan 04 2015 - 02:11:05 EST


On Sun, 2015-01-04 at 12:59 +0600, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov <kuleshovmail@xxxxxxxxx>
[]
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
[]
> @@ -1661,7 +1661,7 @@ void dm_change_dynamic_initgain_thresh(struct net_device *dev,
> dm_digtable.rssi_low_thresh = dm_value;
> } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
> dm_digtable.rssi_high_power_highthresh = dm_value;
> - } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
> + } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW) {
> dm_digtable.rssi_high_power_highthresh = dm_value;
> } else if (dm_type == DIG_TYPE_ENABLE) {
> dm_digtable.dig_state = DM_STA_DIG_MAX;

Presumably, this is a copy/paste error and should have
both lines changed to HIGHPWR_LOW/high_power_lowthresh

else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW)
dm_digtable.rssi_high_power_lowthresh = dm_value;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/