Re: [PATCH v2 2/3] serial: 8250_early: prepare for dynamic BASE_BAUD

[Vineet Gupta]

Hi Peter,

On Monday 05 January 2015 06:31 PM, Peter Hurley wrote:
> Hi Vineet,
>
> On 01/05/2015 06:30 AM, Vineet Gupta wrote:
>> -	port->uartclk = BASE_BAUD * 16;
>> +	port->uartclk = earlycon_base_baud(options) * 16;
> I don't understand why BASE_BAUD can't be defined by arc as arc_earlycon_base_baud().
> Why is the weak binding necessary?

Indeed weak semantics are not really needed - even now we have what u r suggesting
- the missing part was existing conditional definition which will simply go away
if I implement the fdt parsing in that singly defined function. Thx for the tip :-)

In that case this requires no change to driver and I can fixup the platform -
perhaps ur Ack on next version will be nice.
Also what do u think of the early IER optimization ?

>
> I'm pushing back on this because port initialization (and especially 8250)
> is already a ridiculous spiderweb.

I totally agree.

Thx,
-Vineet

>
> Regards,
> Peter Hurley
>
>>  	options = strchr(options, ',');
>>  	if (options) {
>> @@ -156,7 +165,7 @@ int __init of_setup_earlycon(unsigned long addr,
>>  
>>  	port->iotype = UPIO_MEM;
>>  	port->mapbase = addr;
>> -	port->uartclk = BASE_BAUD * 16;
>> +	port->uartclk = earlycon_base_baud(NULL) * 16;
>>  	port->membase = earlycon_map(addr, SZ_4K);
>>  
>>  	early_console_dev.con->data = &early_console_dev;
>>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/