Re: [PATCH v2 2/3] serial: 8250_early: prepare for dynamic BASE_BAUD

[Vineet Gupta]

On Monday 05 January 2015 07:04 PM, Peter Hurley wrote:
>> Also what do u think of the early IER optimization ?
> Seems ok except the commit changelog is wrong: IER is disabled twice per _line_.
> How did you profile it? It's ok if the answer is "seemed faster"; I'm just
> curious.

Looking at the code yes this would be per line - but I vaguely remember seeing it
for every char - this was when debugging a systemC model for 8250. Its been a while...
I'd added prints in the model whenever IER would wiggle and it was just being
written with 0's again and again when in the early polling based printing mode.

I'll send a revised version with fixed changelog.

Thx,
-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/