Re: [PATCH V3 2/2] mm, vmscan: wake up all pfmemalloc-throttled processes at once

[Rik van Riel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/05/2015 03:56 AM, Vlastimil Babka wrote:
> Kswapd in balance_pgdate() currently uses wake_up() on processes
> waiting in throttle_direct_reclaim(), which only wakes up a single
> process. This might leave processes waiting for longer than
> necessary, until the check is reached in the next loop iteration.
> Processes might also be left waiting if zone was fully balanced in
> single iteration. Note that the comment in balance_pgdat() also
> says "Wake them", so waking up a single process does not seem
> intentional.
> 
> Thus, replace wake_up() with wake_up_all().
> 
> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx> Cc: Mel Gorman
> <mgorman@xxxxxxx> Cc: Johannes Weiner <hannes@xxxxxxxxxxx> Cc:
> Michal Hocko <mhocko@xxxxxxx> Cc: Vladimir Davydov
> <vdavydov@xxxxxxxxxxxxx> Cc: Rik van Riel <riel@xxxxxxxxxx>

Acked-by: Rik van Riel <riel@xxxxxxxxxx>

- -- 
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUq08+AAoJEM553pKExN6D9bEIAKV916k0OguiyAGIXrgjPrba
3W2eQ2FFWIm6KwumPas7t6jBzR11yFhpAIACf6nNt12EmH73UwaW2z6vdYque4c+
HU79DXTNTQ91xJfXI8XfNsZW/s8zpCZ+Sm08N7/O7k6c76yKR+owXmoSnjb2Q4N9
O0F0db3Jkd52sH/2l+LCUKrTeI9fRBrKnpAv7FAhZ5go8N7tdtIjYv8hhpIZ/83F
WSRsORt0VKOx0an+JO09e5f6R+RF7RAqiU6yUdDAk52CJzyRqECksLxDOvw81OHD
QUT5TuMVNoqXNJxFpQvyI8Dn82d1CiisX2Wztcic4OlxPJQ6gK04SmeWMXw8Ijw=
=pnD6
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/