Re: [PATCH V2] net: eth: xgene: change APM X-Gene SoC platform ethernet to support ACPI

[David Miller]

From: David Miller <davem@xxxxxxxxxxxxx>
Date: Mon, 05 Jan 2015 22:41:37 -0500 (EST)

> From: Feng Kan <fkan@xxxxxxx>
> Date: Mon,  5 Jan 2015 17:42:56 -0800
> 
>> This adds support for APM X-Gene ethernet driver to use ACPI table to derive
>> ethernet driver parameter.
>> 
>> Signed-off-by: Feng Kan <fkan@xxxxxxx>
> 
> Applied.

Actually, reverted, this breaks the build:

drivers/net/ethernet/apm/xgene/xgene_enet_main.c:1031:28: warning: ʽxgene_enet_of_matchʼ defined but not used [-Wunused-variable]
 static struct of_device_id xgene_enet_of_match[] = {
                            ^
In file included from drivers/net/ethernet/apm/xgene/xgene_enet_main.h:32:0,
                 from drivers/net/ethernet/apm/xgene/xgene_enet_main.c:22:
include/linux/module.h:138:40: error: ʽ__mod_of__xgene_enet_match_device_tableʼ aliased to undefined symbol ʽxgene_enet_matchʼ
   extern const struct type##_device_id __mod_##type##__##name##_device_table \
                                        ^
drivers/net/ethernet/apm/xgene/xgene_enet_main.c:1036:1: note: in expansion of macro ʽMODULE_DEVICE_TABLEʼ
 MODULE_DEVICE_TABLE(of, xgene_enet_match);
 ^