Re: [PATCH v2] mailbox: Add Altera mailbox driver

[Ley Foon Tan]

On Mon, Dec 22, 2014 at 5:44 PM, Ley Foon Tan <lftan@xxxxxxxxxx> wrote:
> The Altera mailbox allows for interprocessor communication. It supports
> only one channel and work as either sender or receiver.
>
> Signed-off-by: Ley Foon Tan <lftan@xxxxxxxxxx>
>
> ---
> v2:
> Resolved comment from Dinh and Suman.
> - Alphabetize the headers.
> - Removed WARN_ON() checking
> - Use devm_kzalloc to allocate struct mbox_chan
> - Change __raw_readl/__raw_writel to readl/writel
> - Check interrupt mode before enable interrupt
> - Change to use module_platform_driver()
> - Remove platform_set_drvdata(pdev, NULL);
> - Fix "Alignment should match open parenthesis" warning
> - Update MAINTAINERS file
> ---

Any further feedback for this v2 patch?

Thanks.

Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/