Re: [PATCH] locking/rwlocks: clean up of qrwlock

[Baoquan He]

On 01/06/15 at 11:13am, Peter Zijlstra wrote:
> On Tue, Jan 06, 2015 at 05:25:42PM +0800, Baoquan He wrote:
> > Hi all,
> > 
> > Thanks for reviewing. 
> > 
> > Do you have any other concerns about this small change?
> 
> I just don't see any point in making the code worse for the 1 arch that
> actually uses it. If there were other archs using it and for them the
> code generation would be negatively impacted (they'd actually generate
> more core because of it) it might be worth looking at.

Hi Peter,

It's OK if you don't like it. I am just a little confused about 2
things:

1) Waiman said "- _QR_BIAS" is used to simulate the xaddr which is only
in x86. So removing it to make it be consistent with other ARCHs, why is
it not good? And you said making the code worse, could you be more
specific?

2) Previously you said this change will make it bigger, I thought you
means the cnts. Am I correct? Or you mean other thing? 

Just want to understand it clearly, please point out what's wrong about
my understanding.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/