Re: [PATCH 1/2] regulator: core: Add a sanity check on the regulator_ enable/disable functions

From: Mark Brown
Date: Tue Jan 06 2015 - 11:03:46 EST


On Tue, Jan 06, 2015 at 01:26:28PM +0100, Gregory CLEMENT wrote:
> On 06/01/2015 13:00, Mark Brown wrote:

> > This really only applies if it's likely that some thing that always gets
> > used if it's there might be missing which isn't the case for regulators,
> > it's not at all common to have power supplies that might be missing and

> Well the pattern the following pattern is very common in the drivers using
> the regulator:

> if (!IS_ERR(regulator_pointer)
> regulator_disable(regulator_pointer);

> So for me it was a good hint that we can factorize it.

It is? It shouldn't be...

Attachment: signature.asc
Description: Digital signature