Re: [PATCH RESEND 3/3] Documentation: Add documentation for rt5033 multifunction device

[Rob Herring]

On Tue, Jan 6, 2015 at 5:34 PM, Beomho Seo <beomho.seo@xxxxxxxxxxx> wrote:
> Thank you for review.
>
> On 01/07/2015 01:54 AM, Rob Herring wrote:
>> On Mon, Jan 5, 2015 at 11:45 PM, Beomho Seo <beomho.seo@xxxxxxxxxxx> wrote:
>>> This patch device tree binding documentation for rt5033 multifunction device.

[...]

>>> +               compatible = "i2c-gpio";
>>> +               standard i2c-gpio constraints...
>>> +               fuelgauge {
>>> +                       compatible = "richtek,rt5033-battery".
>>> +               };
>>> +       };
>>
>> I'm a bit confused by this. The fuelgauge is an i2c device hanging off
>> the rt5033 or a 2nd i2c slave on the rt5033?
>>
>
> It is 2nd i2c slave on the rt5033.

Okay, then you should leave out i2c-gpio from the example. The type of
i2c host is not relevant. You could for example have both slaves
attached to the same master. So just this (at the same level as
rt5033@34)

rt5033@35 {
        compatible = "richtek,rt5033-battery";
        interrupt-parent = <&gpx2>;
        interrupts = <3 0>;
        reg = <0x35>;
};

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/