Re: [PATCH 06/22] [SCSI] mpt2sas, mpt3sas: Removing uppper boundary restriction for the module parameter max_sgl_entries

[Martin K. Petersen]

>>>>> "Sreekanth" == Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxxx> writes:

Sreekanth> I though to warn the user that the module parameter
Sreekanth> max_sgl_entries value what they provided is greater than the
Sreekanth> kernel defined SCSI_MAX_SG_SEGMENTS, whether if this module
Sreekanth> parameter value is greater than or less than the
Sreekanth> SCSI_MAX_SG_CHAIN_SEGMENTS. Also I thought, user may confuse
Sreekanth> if see observes SCSI_MAX_SG_CHAIN_SEGMENTS value instead of
Sreekanth> max_sgl_entries value in the warning message.

I would just prefer to see the value that is in effect. I know what I
provided as override value.

At the very least print a warning if you subsequently clamp the value to
MAX_SG_CHAIN_SEGMENTS. "Requested number of segments %u is bigger than
kernel max %u".

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/