Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

[Rusty Russell]

Kees Cook <keescook@xxxxxxxxxxxx> writes:
> On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
>> Kees, as far as I can tell you need another 0-terminated vmlinux.relocs
>> section for weak symbols.  These should not be relocated if already 0.
>
> A few questions:
>
> Why doesn't this break on 32-bit without kASLR? 32-bit does relocation
> by default, even without CONFIG_RANDOMIZE_BASE.

Well, the offset was 0 until I removed CONFIG_HIBERNATE.

> Are there any symbols that are NULL that aren't weak? I'd expect all
> strong symbols to have non-zero offsets, but I must be
> misunderstanding something here.

I don't think there would be.  Anyway, you might be able to filter them
out in x86/tools/relocs itself.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/