Re: [RFC v4] debug: prevent entering debug mode on panic/exception.

[Kiran Raparthy]

On 7 January 2015 at 02:47, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, 06 Jan 2015 15:25:51 +0000 Daniel Thompson <daniel.thompson@xxxxxxxxxx> wrote:
>
>> >> To avoid entering the debugger on panic/exception without any extra
>> >> configuration, panic_timeout is being used which can be set via
>> >> /proc/sys/kernel/panic at run time and CONFIG_PANIC_TIMEOUT sets the default
>> >> value.
>> >>
>> >> ...
>> >>
>> >
>> > hm.  Why overload the meaning of panic_timeout in this fashion?  If
>> > someone is using kgdb and has panic_timeout set, they'll get quiet a
>> > surprise.
>>
>> Will they?
>>
>> Setting panic_timeout means the user explicitly requested that the
>> machine try to perform an unattended reboot after a panic. Wedging in
>> kgdb during panic on such a system absolutely contradicts the user's
>> request to have an automated reboot.
>>
>> In this case it is not overloading the meaning... we are simply altering
>> kgdb to properly honour the existing meaning.
>>
>> Changing the behaviour for exceptions as well as for panics *might*
>> maybe veer into overloading but even there, I think we are simply better
>> reflecting user intent. It is hard to imagine a user that wants
>> automatic-reboot-on-panic being happy for the kernel to get stuck
>> overnight just because of an oops.
>
> OK, when you put it that way...
>
> Kiran, could we please have an updated patch which includes the above
> observations in the changelog and which documents panic_timeout?
Sure,I'll do that.Thanks for your time.
Regards,
Kiran
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/