Re: [RFC 2/2] x86, vdso, pvclock: Simplify and speed up the vdso pvclock reader
From: Paolo Bonzini
Date: Wed Jan 07 2015 - 00:42:10 EST
On 06/01/2015 19:26, Andy Lutomirski wrote:
> Don't you stil need:
>
> version++;
> write the rest;
> version++;
>
> with possible smp_wmb() in there to keep the compiler from messing around?
No, see my other reply.
Separating the version write is a real bug, but that should be all that
it's needed.
> Also, if you do this, can you also make setting and clearing
> STABLE_BIT properly atomic across all vCPUs? Or at least do something
> like setting it last and clearing it first on vPCU 0?
That would be nice if you want to make the pvclock area fit in a single
page. However, it would have to be a separate flag bit, or a separate
CPUID feature.
Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/