Re: [PATCH -v2 5/5] OOM, PM: make OOM detection in the freezer path raceless
From: Michal Hocko
Date: Wed Jan 07 2015 - 13:48:55 EST
On Wed 07-01-15 13:41:24, Tejun Heo wrote:
> Hello, Michal. Sorry about the long delay.
>
> On Fri, Dec 05, 2014 at 05:41:47PM +0100, Michal Hocko wrote:
> ...
> > @@ -252,6 +220,8 @@ void thaw_kernel_threads(void)
> > {
> > struct task_struct *g, *p;
> >
> > + oom_killer_enable();
> > +
>
> Wouldn't it be more symmetrical and make more sense to enable oom
> killer after kernel threads are thawed? Until kernel threads are
> thawed, it isn't guaranteed that oom killer would be able to make
> forward progress, right?
Makes sense, fixed.
> Other than that, looks good to me.
Thanks! Btw. I plan to repost after Andrew releases new mmotm as there
are some dependencies in oom area.
--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/