Re: livepatching tree for linux-next

[Andrew Morton]

On Thu, 8 Jan 2015 00:49:49 +0100 (CET) Jiri Kosina <jkosina@xxxxxxx> wrote:

> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -911,6 +911,12 @@ static int klp_init(void)
>  {
>  	int ret;
>  
> +	ret = klp_check_compiler_support();
> +	if (ret) {
> +		pr_info("Your compiler is too old; turning off.\n");
> +		return -EINVAL;
> +	}
> +

Looks reasonable.  It's a shame we've never figured out a way to do
this at Kconfig-time.


That second #error doing in livepatch.h is a bit odd.  It errors out if
anyone includes livepatch.h when CONFIG_LIVE_PATCHING=n.  Methinks it
would be saner to change it to

#error include linux/livepatch.h, not asm/livepatch.h



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/