Re: [PATCH] clocksource: tegra: wrap arch/arm-specific sections in CONFIG_ARM

[Thierry Reding]

On Thu, Jan 08, 2015 at 03:21:58PM +0100, Daniel Lezcano wrote:
> On 12/09/2014 11:07 PM, Paul Walmsley wrote:
> >
> >Like several of the other files in drivers/clocksource,
> >tegra20_timer.c contains code that can only compile when CONFIG_ARM is
> >enabled.  This causes obvious problems when trying to compile this
> >code for NVIDIA ARM64-based SoCs, such as Tegra132.  The same timer IP
> >blocks exist, so it seems appropriate to provide support for them.
> >
> >So until we figure out a better way to partition this code, wrap the
> >delay_timer and persistent_clock support code with preprocessor tests
> >for CONFIG_ARM.  (The delay_timer code should not be needed at all on
> >ARM64 due to the presence of the ARMv8 architected timer.  The
> >persistent_clock support code could become important once power
> >management modes are implemented that turn off the CPU complex.)
> 
> Well actually putting #ifdef macros in the C code should be avoided if
> possible.
> 
> May be you can replace those macros by:
> 
> if (IS_ENABLED(CONFIG_ARM64)) {
> 	...
> }
> 
> ?

Unfortunately we can't. Some of the symbols in this file are only
defined in headers specific to ARM and not available on ARM64.

Thierry

Attachment: pgpvwrDGIis8h.pgp
Description: PGP signature