Re: [PATCH] serial: 8250: Make ISA ports optional

[Arnd Bergmann]

On Friday 09 January 2015 00:13:28 Peter Hurley wrote:
> On 01/08/2015 05:05 PM, Arnd Bergmann wrote:
> > On Thursday 08 January 2015 11:11:51 Peter Hurley wrote:
> >>
> >> This interface is just storage and minor allocation, since the
> >> port-reuse behavior will be limited to the "universal" driver.
> >> From a sub-driver perspective, the shared storage is actually
> >> a hindrance, so that reduces the requirement to minor allocation.
> >>
> >> And that's where I'm stuck at the moment -- how to share ttyS
> >> minor allocation. ttyS console is a related problem.
> > 
> > One idea that has come up in the past but never saw an implementation
> > is to make the ttyS namespace and minor numbers completely generic and
> > let any serial port driver use it. This would be a major rework, but
> > have the added advantage of cleaning up a number of other namespace
> > issues as well. There also lots of open question, in particular how
> > to maintain compatibility with existing drivers. One could imagine
> > that each uart always gets a ttyS device and optionally also gets
> > a device node for the same port with a driver specific chardev as
> > most of them do today. Or it could be an either/or decision that is
> > made at compile time or as a module parameter.
> 
> I'm not totally convinced that sharing minor allocation is the right
> solution. ISTM that the main goal is for at least one serial driver
> to represent ttyS (assuming that it is a suitable work-alike to the
> 8250 driver) while other ttyS serial drivers must still be able to
> load and operate.

Unfortunately, we have already seen a case where we need to have
two drivers enabled at the same time that both use the ttyS
namespace and minor numbers at the moment.

> So for example, a UART that is ttyS in a typical configuration, might
> be ttyX when another driver has been configured as ttyS instead.
> Assuming that every uart driver has a unique, alternate base name,
> then the problem is reduced to selecting the appropriate driver for
> ttyS.
> 
> Some use cases would require selecting the ttyS driver at build time.
> Others would probably require the notion of a preferred driver.

Build-time selection looks problematic to me in the case of an
ARM distro kernel that wants to support dozens of different
uart drivers. At the moment this works for the most part because
the conflicts are rare, but it's getting worse.

> What got me thinking about this approach instead of sharing minor
> allocation was based on the 'first-come, first-served' question
> I asked back in Dec. What happens when probe order varies and
> console=ttyS0/login prompt doesn't show up where it's supposed to?
> I've had this experience with multiple ethernet adapters and it's
> not fun.

In a lot of cases, we can solve the problem for a particular board
by hardcoding the 'aliases' in the board specific dts file, at least
when devicetree is used (as it is for the majority of the cases that
are causing problems now).

Using the aliases correctly at the moment is really awkward when you
have multiple drivers for uarts on the same system and your serial0
and serial1 uart turn into ttyS0 and ttyX1.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/