Re: [GIT PULL] make mrproper fix for v3.19-rc4

From: Michal Marek
Date: Fri Jan 09 2015 - 04:40:37 EST


On 2015-01-08 23:42, Linus Torvalds wrote:
> Just do
>
> make allmodconfig
> .. build the tree ..
> make distclean
> git ls-files -o
>
> to see any files that are left-over despite the distclean ("git
> ls-files -o" basically shows all untracked files - 'o' stands for
> 'others' - so anything that isn't in the actual distributed sources
> shows up)

The x86 files should actually be removed by make clean. The bug is that
the $(targets) variable must not depend on the configuration, so that
make clean always knows what to delete. I'll send a patch to the x86
maintainers, but such bugs keep creeping in. Other archs possibly have a
similar prolbem.

security/tomoyo automatically generates files that can also be supplied
by the user, which sucks, because make clean does not know whether they
are generated or user supplied.


> But I really am not sure how much effort we should spend on "make
> distclean", given than "git clean" is so much easier and requires no
> effort at all.

With git clean and git archive, there is indeed little use for make
distclean. But clean and mrproper should work.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/