Re: [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio
From: Russell King - ARM Linux
Date: Fri Jan 09 2015 - 06:45:49 EST
On Fri, Jan 09, 2015 at 12:30:36PM +0100, Jean-Francois Moine wrote:
> In my original version, the audio-ports are a bitmap of the pins, the
> bit 0 being the WS used for I2S. A fully wired tda998x would have been
> as:
>
> audio-ports = <0x03>, <0x04>, <0x09>, <0x11>;
> audio-port-names = "i2s", "spdif", "i2s", "i2s";
>
> With the new version, it would simply become:
>
> audio-inputs = "i2s", "spdif", "i2s", "i2s";
How do you know which i2s inputs to enable?
Does it make sense for the audio inputs to be mixed like that?
You will need to enable one i2s for front L+R, and increasingly others
for the additional channels.
I think we need to understand exactly how the 998x map I2S inputs to the
HDMI channels to avoid making a mistake with the binding; remember, the
binding isn't something that can be easily "bug fixed" at a later date
as anything we come up with now has to be supported long term by the
kernel.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/