Re: [PATCHv2] hwmon: (ina2xx) implement update_interval attribute for ina226

From: Bartosz Golaszewski
Date: Fri Jan 09 2015 - 09:45:32 EST


2015-01-09 15:34 GMT+01:00 Guenter Roeck <linux@xxxxxxxxxxxx>:
> Unfortunately that only applies to INA226 and not INA219, where the time is
> static
> (at least so far).

Oops, I must have missed this one.

> I think we'll need to store the time in ina2xx_data and use the old
> (constant)
> value for ina219. Maybe add another variable into the configuration data
> for the initial value and copy it from there during probe.

I tried to avoid adding another variable used by ina226 only, but
well. It's kind of dull that these chips are supported by a single
driver - their configuration register layout is completely different.

Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/