Re: [PATCH] s390: include: timex: Use macro CLOCK_STORE_SIZE instead of hard code number

[Chen Gang S]

On 1/7/15 23:36, Martin Schwidefsky wrote:
> On Wed, 07 Jan 2015 22:45:11 +0800
> Chen Gang S <gang.chen@xxxxxxxxxxxxx> wrote:
> 
>> On 01/05/2015 04:59 PM, Martin Schwidefsky wrote:
>>> On Sat, 03 Jan 2015 11:44:04 +0800
>>> Chen Gang <gang.chen@xxxxxxxxxxxxx> wrote:
>>>
>>>>
>>>> Thank you for your work.
>>>>
>>>> In honest, originally, I was not sure whether it would cause bug (do not
>>>> know gcc would generic incorrect code for it). :-)
>>>
>>> Even if the code happened to be correct it does not matter. The intention
>>> of the sizeof() has been to get to the correct 16, not 8. The fix is
>>> fine as it is.
>>>
>>
>> Excuse me, my English is not quite well, I am not quite sure about what
>> you said (might misunderstand what you said), so I provide the related
>> information below for confirmation, please check, thanks.
>>
>> sizeof(clk) is for a pointer, not for an array (for C language, it
>> treats array parameter as a pointer), the related demo is below:
> 
> And your patch fixes this problem. My comment was in regard to the
> impact of the original bug. As the typeof construct is used to
> prevent the compiler from over-optimizing, the code can come out
> correct even if the bug is present.
> 

OK, thank you for your reply.

In honest, I still not quite understand your meaning, I guess it is only
because of my poor English, and it doesn't matter for others members, so
not need additional reply for it (but welcome reply).

For details (please check, if still interest):

  > And your patch fixes this problem. My comment was in regard to the
  > impact of the original bug.

    I can understand the 2 contents above.

  >                             As the typeof construct is used to
  > prevent the compiler from over-optimizing,

    I can understand, yeah, typeof() is useful for declaring an array.

  >                                            the code can come out
  > correct even if the bug is present.
  > 

    Sorry, I can not understand: I know every words, and it seems I can
    understand the whole sentence, but for me, it seems have a conflict
    meaning with the original sentences.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/