Re: [RFC Patch 00/19] Improve ACPI resource parsing interfaces and data structures

[Rafael J. Wysocki]

On Thursday, January 08, 2015 10:32:47 AM Jiang Liu wrote:
> During enabling ACPI based IOAPIC hotplug, Thomas noticed some issues
> in ACPI resource parsing interfaces. So this is an effort to improve them.
> 
> Patch 1-12 improve ACPI resource parsing interfaces and also fixes some
> bugs.
> 
> Patch 13-19 try to share the common data structure resource_list_entry
> between PCI and ACPI. It may also be shared with PNP too.

I've looked at the patches briefly.

I like the changes at the general level, but there are some things I'm
potentially concerned about in them.  Need more time to look at them,
I'll do my best to do that this week while at the conference.

> The patchset is based on v3.19-rc3 and you may get it from:
> https://github.com/jiangliu/linux.git acpires_v1
> 
> Jiang Liu (11):
>   ACPI: Fix a bug in parsing ACPI Memroy24 resource
>   ACPI: Normalize return value of resource parser functions
>   ACPI: Set flag IORESOURCE_UNSET for unassigned resources
>   ACPI: Enforce stricter checks for address space descriptors
>   ACPI: Return translation offset when parsing ACPI address space
>     resources
>   ACPI: Translate resource into master side address for bridge window
>     resources
>   ACPI: Add field offset to struct resource_list_entry
>   ACPI: Introduce helper function acpi_dev_filter_resource_type()
>   resources: Move struct resource_list_entry from ACPI into resource
>     core
>   PCI: Use common resource list management code instead of private
>     implementation
>   x86/PCI/ACPI: Use common ACPI resource interfaces to simplify
>     implementation
> 
> Thomas Gleixner (8):
>   ACPI: Remove redundant check in function
>     acpi_dev_resource_address_space()
>   ACPI: Implement proper length checks for mem resources
>   ACPI: Use the length check for io resources as well
>   ACPI: Let the parser return false for disabled resources
>   ACPI: Provide union for address_space64 and ext_address_space64
>   ACPI: Unify the parsing of address_space and ext_address_space
>   ACPI: Move the window flag logic to the combined parser
>   ACPI: Add prefetch decoding to the address space parser
> 
>  arch/arm/kernel/bios32.c            |    5 +-
>  arch/x86/pci/acpi.c                 |  297 ++++++++++---------------------
>  arch/x86/pci/bus_numa.c             |    4 +-
>  drivers/acpi/acpi_lpss.c            |    6 +-
>  drivers/acpi/acpi_platform.c        |    2 +-
>  drivers/acpi/resource.c             |  333 ++++++++++++++++++++++-------------
>  drivers/dma/acpi-dma.c              |    8 +-
>  drivers/pci/bus.c                   |   18 +-
>  drivers/pci/host-bridge.c           |    8 +-
>  drivers/pci/host/pci-host-generic.c |    4 +-
>  drivers/pci/host/pci-xgene.c        |    4 +-
>  drivers/pci/host/pcie-xilinx.c      |    4 +-
>  drivers/pci/probe.c                 |   10 +-
>  drivers/pnp/pnpacpi/rsparser.c      |    4 +-
>  include/acpi/acrestyp.h             |   49 ++++--
>  include/linux/acpi.h                |   12 +-
>  include/linux/ioport.h              |   25 +++
>  include/linux/pci.h                 |    8 +-
>  kernel/resource.c                   |   48 +++++
>  19 files changed, 452 insertions(+), 397 deletions(-)
> 
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/