Re: [PATCH 3/4] x86: open-code register save/restore in trace_hardirqs thunks

From: Denys Vlasenko
Date: Sun Jan 11 2015 - 18:06:33 EST


On Sun, Jan 11, 2015 at 11:54 AM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> On Sun, Jan 11, 2015 at 04:33:58AM +0100, Denys Vlasenko wrote:
>> I understand Andy's post.
>> My question is, what about places like this?
>>
>> > .macro op_safe_regs op
>> > ENTRY(\op\()_safe_regs)
>> > CFI_STARTPROC
>> > pushl_cfi %ebx
>> > pushl_cfi %ebp
>> > pushl_cfi %esi
>> > pushl_cfi %edi
>>
>> Do we need to convert it to use macros which also do
>> "CFI_REL_OFFSET reg, 0" thingy, or not?
>> In either case: why?
>
> What is different at those places to not use the CFI annotations?

Okay, sending a patch which _probably_ does the right thing...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/