Re: [PATCH 2/3] x_tables: Use also dev->ifalias for interface matching

[Eric Dumazet]

On Sun, 2015-01-11 at 21:52 +0100, Richard Weinberger wrote:
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
>  include/linux/netfilter/x_tables.h | 22 ++++++++++++++++++++++
>  net/ipv4/netfilter/arp_tables.c    | 28 +++++++++++++++++-----------
>  net/ipv4/netfilter/ip_tables.c     | 15 +++++----------
>  net/ipv6/netfilter/ip6_tables.c    | 18 +++++++-----------
>  net/netfilter/xt_physdev.c         |  9 ++-------
>  5 files changed, 53 insertions(+), 39 deletions(-)

Richard, I dislike this, sorry.

iptables is already horribly expensive, you add another expensive step
for every rule.

device aliasing can be done from user space.

iptables should have used ifindex, its sad we allowed the substring
match in first place.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/