Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

[Arend van Spriel]

On 01/12/15 15:06, Sergei Shtylyov wrote:
> Hello.
>
> On 1/12/2015 9:41 AM, Fu, Zhonghui wrote:
>
> > From 8685c3c2746b4275fc808d9db23c364b2f54b52a Mon Sep 17 00:00:00 2001
> > From: Zhonghui Fu <zhonghui.fu@xxxxxxxxxxxxxxx>
> > Date: Mon, 12 Jan 2015 14:25:46 +0800
> > Subject: [PATCH] brcmfmac: avoid duplicated suspend/resume operation
>
> The lines above are not needed.
>
> > WiFi chip has 2 SDIO functions, and PM core will trigger
> > twice suspend/resume operations for one WiFi chip to do
> > the same things. This patch avoid this case.
>
> > Acked-by: Arend van Spriel<arend@xxxxxxxxxxxx>
> > Acked-by: Sergei Shtylyov<sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Zhonghui Fu <zhonghui.fu@xxxxxxxxxxxxxxx>
> > ---
> > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 21
> > +++++++++++++++++----
> > 1 files changed, 17 insertions(+), 4 deletions(-)
>
> > diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> > b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> > index 9880dae..8f71485 100644
> > --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> > +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> > @@ -1070,7 +1070,7 @@ static int brcmf_ops_sdio_probe(struct sdio_func
> > *func,
> > */
> > if ((sdio_get_host_pm_caps(sdiodev->func[1]) & MMC_PM_KEEP_POWER) &&
> > ((sdio_get_host_pm_caps(sdiodev->func[1]) & MMC_PM_WAKE_SDIO_IRQ) ||
> > - (sdiodev->pdata && sdiodev->pdata->oob_irq_supported)))
> > + (sdiodev->pdata->oob_irq_supported)))
>
> Inner parens not needed on this line.

Well, actually this patch should not affect those line as it would 
reintroduce a recently fixed issue.

Regards,
Arend

> [...]
>
> WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/