Re: [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver

[Arnd Bergmann]

On Monday 12 January 2015 14:40:09 Rameshwar Sahu wrote:
> > +
> > +       dma_set_mask_and_coherent(&pdev->dev,
> > +                                 (sizeof(dma_addr_t) == sizeof(u64)) ?
> > +                                 DMA_BIT_MASK(64) : DMA_BIT_MASK(32));
> > +
> 

I commented on this on v1 already: always set the device specific mask here,
it's independent of the CPU architecture, but do check the return value.

Also add the correct dma-ranges property in the parent, or else this will
fail in the future once we add proper checks to dma_set_mask.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/